Disable UnnecessaryStringOutput haml linter #1131
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The linter prefers `%p Note: #{order_detail.note}` to `%p= "Note:
#{order_detail.note}”`. We usually go with the latter where the string
interpolation is explicit.
|
I kind of prefer the former, but don't really have strong feelings about it either way. |
|
I would probably go with the explicit string interpolation option, but I don't have strong feelings about it. With style things, I tend to bias towards the more obvious formatting, just because I think it helps make codebases friendlier for newer devs. |
meara
approved these changes
Jun 26, 2017
|
I prefer it with |
|
I'm fine with either |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The linter prefers
%p Note: #{order_detail.note}to%p= "Note: #{order_detail.note}”. We usually go with the latter where the stringinterpolation is explicit.
I'm open to debate on this. This can probably wait until Meara is back so she can weigh in on it.