Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#161996] Stepped billing Documentation #3825

Merged
merged 8 commits into from
Dec 12, 2023
Merged

Conversation

LeticiaErrandonea
Copy link
Contributor

Release Notes

Documentation for Stepped billing. Also includes already existing logic for pricing.

@LeticiaErrandonea LeticiaErrandonea marked this pull request as ready for review November 17, 2023 19:05
@LeticiaErrandonea LeticiaErrandonea requested a review from a team as a code owner November 17, 2023 19:05
Copy link
Contributor

@giladshanan giladshanan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work, left some suggestions and questions

doc/product_pricing.md Outdated Show resolved Hide resolved
doc/product_pricing.md Outdated Show resolved Hide resolved
doc/product_pricing.md Outdated Show resolved Hide resolved
doc/product_pricing.md Show resolved Hide resolved
doc/product_pricing.md Outdated Show resolved Hide resolved
When using this Priicng mode, the user will pay an hourly rate defined by the price group they belong to.

#### Duration based
In this mode, there are up to 4 rates for each price policy. These rates apply to a given step, which is defined by setting a Rate start (hr). Price policies can either have no steps defined (just the usage rate) or all of them. It's invalid to set two or three steps.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
In this mode, there are up to 4 rates for each price policy. These rates apply to a given step, which is defined by setting a Rate start (hr). Price policies can either have no steps defined (just the usage rate) or all of them. It's invalid to set two or three steps.
In this mode, sometimes referred to as "Stepped Billing" mode, there are up to 4 rates for each price policy. These rates apply to a given step, which is defined by setting a Rate start (hr). Price policies can either have no steps defined (just the usage rate) or all of them. It's invalid to set rates for one or two steps.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I found this tricky. We say there are 4 steps (usage rate/subsidy + 3 duration rates) but then we want to say you either set all or none of them. I wonder what's the best way to be clear about this.

Maybe something like It's invalid to set rates for one or two additional steps.?

doc/product_pricing.md Outdated Show resolved Hide resolved
doc/product_pricing.md Outdated Show resolved Hide resolved
doc/product_pricing.md Outdated Show resolved Hide resolved
LeticiaErrandonea and others added 3 commits December 12, 2023 11:30
Co-authored-by: Gilad Shanan <30355046+giladshanan@users.noreply.github.com>
Co-authored-by: Gilad Shanan <30355046+giladshanan@users.noreply.github.com>
@LeticiaErrandonea LeticiaErrandonea merged commit 791537e into master Dec 12, 2023
3 checks passed
@LeticiaErrandonea LeticiaErrandonea deleted the 161996-documentation branch December 12, 2023 19:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants