Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#162000] Tech task: Update Scishield sync batch sleep time default #3869

Merged
merged 1 commit into from
Dec 1, 2023

Conversation

jossim
Copy link
Contributor

@jossim jossim commented Nov 30, 2023

Release Notes

This updates the default sleep time to 20 seconds.

Updating environment variables for OSU is a bit cumbersome, so this just sets the default to what OSU would use

Copy link
Contributor

@giladshanan giladshanan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are you planning to update the ENV for UMass then? We should add a manual task to release notes

@jossim
Copy link
Contributor Author

jossim commented Nov 30, 2023

@giladshanan UMass should work fine with this default. Though if there's a reason to change it back to 0 seconds, a manual task can be added.

The 20 second default is already in OSU, so this PR is just porting that to open. I'd guess this doesn't need to go into the release this time, since it's only for OSU

@giladshanan
Copy link
Contributor

@jossim let's save this for next release

@jossim jossim merged commit c21738f into master Dec 1, 2023
3 checks passed
@jossim jossim deleted the 162000-batch-default-settings branch December 1, 2023 15:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants