[#161995] [Shared dev] Duration based pricing - (5) Duration discounts applied to user reservation #3872
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LeticiaErrandonea
force-pushed
the
161995-duration-based-for-internal-groups
branch
from
279806c
to
4a72f83
Compare
giladshanan
requested changes
Dec 5, 2023
giladshanan
reviewed
Dec 5, 2023
LeticiaErrandonea
force-pushed
the
161995-duration-based-for-internal-groups
branch
from
6c9afa1
to
351dd9a
Compare
giladshanan
reviewed
Dec 6, 2023
| class DurationRate < ApplicationRecord; end | ||
|
|
||
| def change | ||
| DurationRate.delete_all |
There was a problem hiding this comment.
We should make a note to do some manual testing around this before releasing
There was a problem hiding this comment.
You mean like checking that price policies aren't broken? Any other cases you can think of?
There was a problem hiding this comment.
If we have any duration rate records on production, we should check if any orders have been placed against them. I don't think anyone is using this yet but I just want to be safe
- DurationRate
- Rate always present
- Subsidy required for internal (not base)
- subsidy <= rate
- Price policy
- Each group can have either none or 3 duration rates
LeticiaErrandonea
force-pushed
the
161995-duration-based-for-internal-groups
branch
from
0e6ba7c
to
6cffee5
Compare
* Bump teaspoon from 1.2.2 to 1.4.0 Bumps [teaspoon](https://github.com/jejacks0n/teaspoon) from 1.2.2 to 1.4.0. - [Release notes](https://github.com/jejacks0n/teaspoon/releases) - [Changelog](https://github.com/jejacks0n/teaspoon/blob/master/CHANGELOG.md) - [Commits](jejacks0n/teaspoon@v1.2.2...v1.4.0) --- updated-dependencies: - dependency-name: teaspoon dependency-type: indirect update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> * Bump teaspoon from 1.2.2 to 1.4.0 Bumps [teaspoon](https://github.com/jejacks0n/teaspoon) from 1.2.2 to 1.4.0. - [Release notes](https://github.com/jejacks0n/teaspoon/releases) - [Changelog](https://github.com/jejacks0n/teaspoon/blob/master/CHANGELOG.md) - [Commits](jejacks0n/teaspoon@v1.2.2...v1.4.0) --- updated-dependencies: - dependency-name: teaspoon dependency-type: indirect update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> * Use an older image tag for selenium --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Gilad Shanan <giladshanan@gmail.com>
- DurationRate
- Rate always present
- Subsidy required for internal (not base)
- subsidy <= rate
- Price policy
- Each group can have either none or 3 duration rates
…ithub.com/tablexi/nucore-open into 161995-duration-based-for-internal-groups
LeticiaErrandonea
deleted the
161995-duration-based-for-internal-groups
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Release Notes
Screenshot