Skip to content
This repository has been archived by the owner on Jan 15, 2024. It is now read-only.

Update dependencies and lint for errors #426

Merged
merged 6 commits into from
Oct 27, 2020
Merged

Update dependencies and lint for errors #426

merged 6 commits into from
Oct 27, 2020

Conversation

Soitora
Copy link
Member

@Soitora Soitora commented Oct 27, 2020

Dependencies and linting in the same PR, specifically because one of the packages would fail if it wasn't linted for at the same time (I believe it was eslint-config-vuepress 2.2.0->3.0.1).

Changes

  • Update all node packages.
  • Change element-ui plugin tags to PascalCase. (Does not work with the ::: elements though so need kebab-case for that still.)
  • Using slots="name" is now outdated, so switched to #name which is an even newer version of v-slot:name.
  • ESLint disabled two lines, one of which is needed (afaik) for What's New box and one of which is Vuepress native and not controlled by us.

@netlify
Copy link

netlify bot commented Oct 27, 2020

Deploy preview for tachiyomi ready!

Built with commit 56c94f4

https://deploy-preview-426--tachiyomi.netlify.app

@Soitora
Copy link
Member Author

Soitora commented Oct 27, 2020

Nice Error: Cannot find module 'webpack', an error that did not occur for me even with a fresh node-modules...

Netlify gave an error for not having it but it wasn't needed before.
@Soitora
Copy link
Member Author

Soitora commented Oct 27, 2020

Whyyyyyyyyyyyyyyyyyyyyyyy you do this
image

Some users have experienced the Netlify error when upgrading to recently released version 5, so downgrading to latest 4 release.
@ghostbear ghostbear merged commit f4fd87a into tachiyomiorg:master Oct 27, 2020
arkon pushed a commit that referenced this pull request Oct 27, 2020
* Update dependencies

* Update eslint-config-vuepress and fix warnings

* Linting

* Save webpack locally

Netlify gave an error for not having it but it wasn't needed before.

* Downgrade webpack

Some users have experienced the Netlify error when upgrading to recently released version 5, so downgrading to latest 4 release.

* Set 'htmlWhitespaceSensitivity' to 'ignore' f4fd87a
@Soitora Soitora deleted the updateDependencies-20201027 branch October 27, 2020 17:49
arkon pushed a commit that referenced this pull request Aug 10, 2021
* Update dependencies

* Update eslint-config-vuepress and fix warnings

* Linting

* Save webpack locally

Netlify gave an error for not having it but it wasn't needed before.

* Downgrade webpack

Some users have experienced the Netlify error when upgrading to recently released version 5, so downgrading to latest 4 release.

* Set 'htmlWhitespaceSensitivity' to 'ignore'
arkon pushed a commit that referenced this pull request Aug 10, 2021
* Update dependencies

* Update eslint-config-vuepress and fix warnings

* Linting

* Save webpack locally

Netlify gave an error for not having it but it wasn't needed before.

* Downgrade webpack

Some users have experienced the Netlify error when upgrading to recently released version 5, so downgrading to latest 4 release.

* Set 'htmlWhitespaceSensitivity' to 'ignore' ce39645
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants