Add FAQ links for individual extensions in list #961
Conversation
❌ Deploy Preview for tachiyomi failed.
|
✅ Deploy Preview for tachiyomi ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
|
I think #841 was referring to the FAQ/Changelog entries here https://github.com/tachiyomiorg/tachiyomi-extensions/tree/master/src/all/batoto |
|
Indeed it is. The index JSON indicates if it exists. |
|
I updated the PR to use the index JSON, but it seems like the index JSON is including some extensions that don't have folders in the tachiyomi-extensions repo as having readmes e.g. Nocturnal scans, Asura scans, miauscan? |
| @@ -18,6 +18,10 @@ export default { | |||
| apkUrl: function () { | |||
| return `https://raw.githubusercontent.com/tachiyomiorg/tachiyomi-extensions/repo/apk/${this.item.apk}`; | |||
| }, | |||
| faq: function () { | |||
| if (!this.item.hasReadme) return undefined; | |||
| return `https://github.com/tachiyomiorg/tachiyomi-extensions/blob/master/src/${this.pkgId.replace('.', '/')}`; | |||
There was a problem hiding this comment.
It's actually a bit more complicated than that -- https://github.com/tachiyomiorg/tachiyomi/blob/master/app/src/main/java/eu/kanade/tachiyomi/ui/browse/extension/details/ExtensionDetailsPresenter.kt#L124-L134
There was a problem hiding this comment.
Ok I can build the url for the multisrc packages but I'm not seeing a way to distinguish which ones need it from the index.json, so I took a stab at making a PR to add it tachiyomiorg/tachiyomi-extensions#14023. I haven't tested it myself and it needs a maintainer to approve the workflow run
|
Since your blocked PR https://github.com/tachiyomiorg/tachiyomi-extensions/pull/14023 got inactive, then this should be assumed inactive too unless you revive it. |
See #841