Skip to content
This repository has been archived by the owner on Jan 15, 2024. It is now read-only.

Old Update document: Remove unnecessary sections & Add extension FAQ mention #1019

Closed
wants to merge 3 commits into from

Conversation

YeiserBytes
Copy link

@YeiserBytes YeiserBytes commented Jul 10, 2023

This pull request includes the following changes:

  • Removal of unnecessary sections about MangaDex, Mangakakalot, Manganelo, Mangabat, Mangairo, and MangaPark.
  • Addition of a mention regarding extension-specific FAQs and guides.

These modifications aim to streamline the document by removing irrelevant information and highlighting the availability of FAQs and guides for extensions. This improves the overall clarity and user experience of the document.

Please review and merge these changes at your convenience. Thank you!

@netlify
Copy link

netlify bot commented Jul 10, 2023

Deploy Preview for tachiyomi failed.

Name Link
🔨 Latest commit b27581a
🔍 Latest deploy log https://app.netlify.com/sites/tachiyomi/deploys/64ab8742e7faff00082865cd

@scb261
Copy link
Contributor

scb261 commented Jul 10, 2023

Don't include package-lock.json changes with the site content changes. If you actually want to make some changes to it - make a different branch with those changes and open a separate pull request from that branch.

Also advice for future: don't make changes on the main branch. Instead keep the main branch the same as upstream, and make your changes in different branches. This way you won't need to overwrite your local main branch when pulling changes from upstream.

@YeiserBytes
Copy link
Author

Thank you for the feedback! I apologize for including the package-lock.json changes in this pull request. I will make sure to separate the changes and create a new branch for any modifications to package-lock.json in the future.

Regarding your advice for future changes, I completely agree. It would be more appropriate to keep the main branch in sync with the upstream and create separate branches for making changes. This way, we can easily pull changes from upstream without overwriting the local main branch.

Once again, thank you for the guidance. I will address these points and make the necessary adjustments.

@loocool2
Copy link
Collaborator

I don't think this PR makes sense as-is, you've removed the sections about each extension but in your new section you say there's extension specific guides but not where to find this extension-specific FAQ at all.
Most extensions don't need any guides at all, so mentioning that an extension may have a FAQ and letting the user figure out where to find it, if it even has one, isn't very user-friendly.
If you're going to remove the extension-specific sections, I'd add some way to read the readme.md files from the tachiyomi-extensions repo into the site somehow so users can discover which ones have an extension-specific faq without needing to poke around in the repo.

@YeiserBytes YeiserBytes closed this by deleting the head repository Jul 10, 2023
@arkon
Copy link
Contributor

arkon commented Jul 10, 2023

Would need to revive #961 before removing that info, or at least just linking to things manually.

@YeiserBytes YeiserBytes changed the title Update document: Remove unnecessary sections & Add extension FAQ mention Old Update document: Remove unnecessary sections & Add extension FAQ mention Jul 11, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants