-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FIX [packageLookup] setOfficialApt for packages with the same name #15
Conversation
with the same name If two or more "apt" packages have the same name, then an official field has has been set only for the last on the list. Now all "apt" packages go through checking process.
packageLookup/apt.go
Outdated
// extract keys from the map of all packages | ||
func officialMapToList(officialMap map[string]*Package) []string { | ||
// getNameOfPackages returns the name of the packages | ||
func getNameOfPackages(packages []*Package) []string { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
getNamesOfPackages
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done. renamed getNamesOfPackages
-> getNamesOfPackages
packageLookup/apt_test.go
Outdated
@@ -124,15 +116,15 @@ func TestGetRepositoriesFromSourcesList(t *testing.T) { | |||
} | |||
|
|||
func TestOfficialMapToList(t *testing.T) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You renamed this method.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Function has been renamed.
You forgot to squash your commits. |
If two or more "apt" packages have the same name, then an
official field has has been set only for the last on the list.
Now all "apt" packages go through checking process.