FIX [packageLookup] setOfficialApt for packages with the same name #15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
with the same name If two or more "apt" packages have the same name, then an official field has has been set only for the last on the list. Now all "apt" packages go through checking process.
dominikznidar
suggested changes
Aug 18, 2017
packageLookup/apt.go
Outdated
| // extract keys from the map of all packages | ||
| func officialMapToList(officialMap map[string]*Package) []string { | ||
| // getNameOfPackages returns the name of the packages | ||
| func getNameOfPackages(packages []*Package) []string { |
There was a problem hiding this comment.
Done. renamed getNamesOfPackages -> getNamesOfPackages
packageLookup/apt_test.go
Outdated
| @@ -124,15 +116,15 @@ func TestGetRepositoriesFromSourcesList(t *testing.T) { | |||
| } | |||
|
|
|||
| func TestOfficialMapToList(t *testing.T) { | |||
There was a problem hiding this comment.
You renamed this method.
There was a problem hiding this comment.
Function has been renamed.
dominikznidar
approved these changes
Aug 18, 2017
|
You forgot to squash your commits. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If two or more "apt" packages have the same name, then an
official field has has been set only for the last on the list.
Now all "apt" packages go through checking process.