Do not turn consecutive spaces in pg_config output into empty cc/ld arguments #348
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The change in f8e475b was a hasty measure on discovering that the single quotes in a quoted argument reported by pg_config may appear within the argument rather than only surrounding it. It solved that problem, but can be fooled into empty arguments where multiple spaces separate arguments in the pg_config output (issue #347). Revert to the regex-based approach from before f8e475b and just tweak that. This implementation openly does not handle the case of an argument containing a single quote as content. PostgreSQL's own build process failed in a simple test of such a case, so supporting it here is probably not necessary for now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The change in f8e475b was a hasty measure on discovering that the single quotes in a quoted argument reported by
pg_configmay appear within the argument rather than only surrounding it. It solved that problem, but can be fooled into empty arguments where multiple spaces separate arguments in thepg_configoutput (issue #347).Revert to the regex-based approach from before f8e475b and just tweak that.
This implementation openly makes no allowance for an argument having a single quote in its content. PostgreSQL's own build process failed in a simple attempt to create such a case, so supporting it here is probably not necessary for now.