Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Request: Only suggest words longer than X characters #125

Closed
Ampa opened this issue May 8, 2022 · 9 comments
Closed

Feature Request: Only suggest words longer than X characters #125

Ampa opened this issue May 8, 2022 · 9 comments
Assignees
Labels
enhancement New feature or request

Comments

@Ampa
Copy link

Ampa commented May 8, 2022

Suggestions are only really useful if they save keypresses. I find that suggestions for short words (3 or 4 characters) actually slow down my typing.

Could we have a slider so specify the minimum length of words that should be suggested?

Example… I specify a minimum suggestion length of 5 characters.

I type 'car'.
I don't want suggestions of: cart, card, cars, carp
I do want suggestions of: cargo, carol, carry, carrying etc.

Secondly, could we specify a sort order for the suggestions, with longer words at the top of the list?
Again, useful as this saves the largest number of key strokes.

Thank you for your consideration, and time writing the plugin.

@aubreyz
Copy link

aubreyz commented May 8, 2022

Indeed +1 to both suggestions

@tadashi-aikawa
Copy link
Owner

Hi, @Ampa. Thank you for your FR :)

First of all, Could you tell me your settings by this command?

@Ampa
Copy link
Author

Ampa commented May 9, 2022

Here are my setting. Not sure that I've changed any from default...

{
"version": "6.0.0",
"mobile": false,
"settings": {
"strategy": "english-only",
"matchStrategy": "prefix",
"maxNumberOfSuggestions": 5,
"maxNumberOfWordsAsPhrase": 3,
"minNumberOfCharactersTriggered": 0,
"minNumberOfWordsTriggeredPhrase": 1,
"complementAutomatically": true,
"delayMilliSeconds": 0,
"disableSuggestionsDuringImeOn": false,
"insertAfterCompletion": true,
"firstCharactersDisableSuggestions": ":/^",
"showMatchStrategy": true,
"showIndexingStatus": true,
"descriptionOnSuggestion": "Short",
"selectSuggestionKeys": "Enter",
"additionalCycleThroughSuggestionsKeys": "None",
"openSourceFileKey": "None",
"propagateEsc": false,
"enableCurrentFileComplement": true,
"onlyComplementEnglishOnCurrentFileComplement": false,
"enableCurrentVaultComplement": true,
"includeCurrentVaultPathPrefixPatterns": "",
"excludeCurrentVaultPathPrefixPatterns": "",
"includeCurrentVaultOnlyFilesUnderCurrentDirectory": false,
"enableCustomDictionaryComplement": false,
"customDictionaryPaths": "https://raw.githubusercontent.com/first20hours/google-10000-english/master/google-10000-english-no-swears.txt",
"columnDelimiter": "Tab",
"customDictionaryWordRegexPattern": "",
"delimiterToHideSuggestion": "",
"delimiterToDivideSuggestionsForDisplayFromInsertion": "",
"caretLocationSymbolAfterComplement": "",
"displayedTextSuffix": " => ...",
"enableInternalLinkComplement": true,
"suggestInternalLinkWithAlias": true,
"excludeInternalLinkPathPrefixPatterns": "",
"enableFrontMatterComplement": true,
"frontMatterComplementMatchStrategy": "inherit",
"insertCommaAfterFrontMatterCompletion": false,
"showLogAboutPerformanceInConsole": false,
"selectionHistoryTree": null
}
}

@tadashi-aikawa
Copy link
Owner

Thank you @Ampa !

I wanted to know what features you use.

From the above,

I type 'car'.
I don't want suggestions of: cart, card, cars, carp
I do want suggestions of: cargo, carol, carry, carrying etc.

I know that your annoying is about Current file complement or Current vault complement.

(On the other hand, it is not always true that is better about the other three features)


Could we have a slider so specify the minimum length of words that should be suggested?

Yes. It looks good, so I'll implement it about Current file complement and Current vault complement👍

Secondly, could we specify a sort order for the suggestions, with longer words at the top of the list?

Yes. However, it would be helpful to create another issue :)

@tadashi-aikawa tadashi-aikawa added the enhancement New feature or request label May 9, 2022
@tadashi-aikawa tadashi-aikawa self-assigned this May 9, 2022
@Ampa
Copy link
Author

Ampa commented May 9, 2022

it would be helpful to create another issue :)

Done!

@Glint-Eye
Copy link

Suggestions are only really useful if they save keypresses. I find that suggestions for short words (3 or 4 characters) actually slow down my typing.

Could we have a slider so specify the minimum length of words that should be suggested?

Example… I specify a minimum suggestion length of 5 characters.

I type 'car'. I don't want suggestions of: cart, card, cars, carp I do want suggestions of: cargo, carol, carry, carrying etc.

Secondly, could we specify a sort order for the suggestions, with longer words at the top of the list? Again, useful as this saves the largest number of key strokes.

Thank you for your consideration, and time writing the plugin.

I also agree with both suggestions.

tadashi-aikawa added a commit that referenced this issue May 29, 2022
@tadashi-aikawa
Copy link
Owner

@Ampa @aubreyz @Glint-Eye
I have released v7.0.0-beta5 🚀

If you use BRAT, please confirm whether it works as you expected.

@tadashi-aikawa
Copy link
Owner

Released in v7.0.0 🚀

@Ampa
Copy link
Author

Ampa commented Jun 29, 2022

Thank you for this addition.

It is working well for me (and I hope for others too!).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Development

No branches or pull requests

4 participants