-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Disable arrow keys for selecting suggestions #129
Comments
Yes. it would be very good to be able to disable arrow up/down keys especially if you work with lists a lot and jump around between items. Also it would be great if "Right / Left Arrow" could be an option for cycling through suggestions as it is still very quick but not that disrupting. Usually I navigate inbetween words with ctrl + left / right anyways, so there isnt a conflict that often. |
@aubreyz |
You are doing great work. |
Thanks for your confirming, @aubreyz :)
I implemented as you said, and confirmed it 🤔 |
Indeed. I think the overall emphasis (for seamless operation) should be that if the user presses any special navigation key other than the ones specifically marked for use to navigate the list or to select a word for completion, the list should close and the key should be passed to the editor. I think that is not just for the arrow case here but for everything So if I type freq(downarrow), -- with arrows turned off -- a list should pop up and then disappear, but the overall effect should be as if the plugin was not installed. If exactly the same way if I currently type freq(forwardarrow) it works well freq(Home) works well So my point is that it should be consistent - and at the moment it is except for up-down-arrows and end (of the ones I tested) I am distressed by your sad face..... it should be a happy hero face |
@aubreyz In my environment, it works as you said (If I didn't misunderstand)
Is the above behavior not what you want? Or doesn't it work like the above in your environment? |
No my environment does not do that. Your video shows exactly how it should be. When I press the up and down arrow what happens is just nothing -- i.e as if no key was pressed and the list remains open. Here is the first part of my data file:
|
@aubreyz What is your OS? (Windows / Mac / Android / iPhone / iPad...) |
Windows 10 |
Umm... I use Windows 10, too. Could you tell me your settings by this command? I want to adapt your settings directly to my environment. |
{ Let me know what happens. Depending on that I could try in a fresh vault with no other plugins. |
I ruled out a few things -- the problem is not altered by |
I confirmed with a new vault and your settings but couldn't reproduce it. 1 Open Are there any errors on the devtools console in the Obsidian? |
I created a new vault Unfortunately the difficulty remains..... I then deleted the data.json and restarted obsidian, and then changed only two default settings Unfortunately still your video is not replicated...... So am not sure |
If you installed via BRAT, The version is 7.0.0-beta8. The below is my settings (new vault). {
"version": "7.0.0-beta8",
"mobile": false,
"settings": {
....
}
} Could you confirm the version in your settings by this command?
I confirm the keycode of Could you tell me the result? |
Ahh.. The way I installed the beta is to simply overwrite all of the existing styles.css From the beta, while keeping the dat file. All the new beta features appeared on the menu, but the version is still reported as 6.1.0 on the dump However the manifest.json in the beta for version 7 downloaded here The manifest-beta.json But obviously the code in main.json main.js has just one version. If I replace the manifest.json with manifest-beta.json the version is reported differently but nothing else changes |
The downarrow key is reported as 40 with the same other settings as yours |
Apart from knowing how to get into the devtools (Control Shift I), I have no experience to know where I would look for errors within that. |
@aubreyz I'm not confident, but please try it. |
The beta9 solves it!!!! |
Greaaaaaat!! Thanks a lot 😄 |
Released in v7.0.0 🚀 |
@aubreyz
I see. What I can do is add a new option named "Disable arrow keys for selecting suggestions". What do you think?
Originally posted by @tadashi-aikawa in #124 (comment)
The text was updated successfully, but these errors were encountered: