Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Algorithm for Intelligent suggestion - possible tweaking #131

Closed
aubreyz opened this issue May 13, 2022 · 5 comments
Closed

Algorithm for Intelligent suggestion - possible tweaking #131

aubreyz opened this issue May 13, 2022 · 5 comments
Assignees
Labels
enhancement New feature or request

Comments

@aubreyz
Copy link

aubreyz commented May 13, 2022

Intelligent suggestion works great!

However I wonder if the algorithm should be tweaked.
https://tadashi-aikawa.github.io/docs-obsidian-various-complements-plugin/1.%20Features/Intelligent%20suggestion%20prioritization/

I agree that recent use should factor in, but
a) it is less sensible that it is a particular time-scale. If abracadabra is the best suggestion to abr because every time I type abr that is what I want, then it makes no difference whether the last use was 5 minutes ago or 5 weeks ago.

I'd suggest if possible that "last use" should get weighted much higher than the exact time of last use.

b) A bigger issue is why the data (i.e selected times) should be cleared within 30 days (and why it should be cleared ever). Not sure what a good reason for this is? I don't want it forgotten if it was the main choice for that trigger phrase. The bonuses of less than 1 for older use seems more than enough to prevent a score from ever being changed if I suddenly find a new field of work.

I would be inclined to leave the bonus as it with a 0.25 factor for >30 days, is but NOT make the selected expire.

So that something used 100 days ago would be retained if it is the best match

@tadashi-aikawa
Copy link
Owner

Hi, @aubreyz.

I'd suggest if possible that "last use" should get weighted much higher than the exact time of last use.

I agree with you 👍

why the data (i.e selected times) should be cleared within 30 days (and why it should be cleared ever).

Intelligent suggestion prioritization saves the history to data.json stored in the plugin directory. If we use Obsidian sync, Obsidian synchronizes data.json with other machines via the network. Therefore I don't want to increase history data as much as possible. That is the reason.

However, I know that there is anyone like you who want to remember more than 30 days. So I'll add an option to specify the period instead of Within 30 days.

@tadashi-aikawa tadashi-aikawa self-assigned this May 14, 2022
@tadashi-aikawa tadashi-aikawa added the enhancement New feature or request label May 14, 2022
@tadashi-aikawa
Copy link
Owner

@aubreyz

I'd suggest if possible that "last use" should get weighted much higher than the exact time of last use.

Released in v7.2.0-beta1 🚀

If you use BRAT, please confirm whether it works as you expected.

tadashi-aikawa added a commit that referenced this issue Aug 21, 2022
…tions for Intelligent suggestion prioritization (#131)
@tadashi-aikawa
Copy link
Owner

tadashi-aikawa commented Aug 21, 2022

@aubreyz

A bigger issue is why the data (i.e selected times) should be cleared within 30 days (and why it should be cleared ever).

#159 (comment)

Released in v7.2.0-beta2 🚀

If you use BRAT, please confirm whether it works as you expected.

image

@aubreyz
Copy link
Author

aubreyz commented Aug 21, 2022

Thank you for this. I am away from my obsidian over the next week, and will try the beta when back home. Sound good

@tadashi-aikawa
Copy link
Owner

I have released in v7.2.0 🚀 (Because Obsidian v16.0 was released, and had some bugs)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Development

No branches or pull requests

2 participants