Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request] Disable Tab key trigger for show suggestions and Consistent Home/End Keys #221

Closed
woshitoutouge opened this issue Apr 12, 2023 · 12 comments
Assignees
Labels
enhancement New feature or request

Comments

@woshitoutouge
Copy link

  1. Disable Tab key trigger for show suggestions

I often use Tab key to indent, but it always trigger show suggestions (depend on the cursor location), which may cause accidental clicks, any way to disable the Tab trigger?

  1. Consistent Home key and End key functionality

I hope the home key and the end key always move the cursor to the beginning and the end of the line, but when the suggestion box is triggered, the home key and the end key change to select the first and the last entry. Is there any way to solve it?

Thanks again for developing such a great plugin!

@tadashi-aikawa
Copy link
Owner

Hi, @woshitoutouge :)

I often use Tab key to indent, but it always trigger show suggestions (depend on the cursor location), which may cause accidental clicks, any way to disable the Tab trigger?

No. But I agree with you. So I'll try to solve the problem.

I hope the home key and the end key always move the cursor to the beginning and the end of the line, but when the suggestion box is triggered, the home key and the end key change to select the first and the last entry. Is there any way to solve it?

Perhaps, it is because of the latest Obsidian updating. I agree with your opinion, so I'll try to solve it, too.

@tadashi-aikawa tadashi-aikawa self-assigned this Apr 14, 2023
@tadashi-aikawa tadashi-aikawa added the enhancement New feature or request label Apr 14, 2023
@tadashi-aikawa
Copy link
Owner

@woshitoutouge
Released in v8.2.0-beta2 🚀

If you use BRAT, please confirm whether it works as you expected.

@woshitoutouge
Copy link
Author

@tadashi-aikawa That works perfectly as i wish! Apreciate your excellent work!

@tadashi-aikawa
Copy link
Owner

I found some more cases should be suppressed.

2023-04-30-12-34-23

I have succeeded in suppressing these cases and will in the next release.

@woshitoutouge
Copy link
Author

Explicit trigger scenarios would be great!

@tadashi-aikawa
Copy link
Owner

Released in v8.2.0 🚀

@woshitoutouge
Copy link
Author

woshitoutouge commented May 12, 2023

after I updated OB, the pop-up box cannot be closed using left key, right key, home or end key... It's really tough for plugin developers

@tadashi-aikawa
Copy link
Owner

after I updated OB, the pop-up box cannot be closed using left key, right key, home or end key...

I didn't reproduce it on Obsidian v1.3.0 and Various Complements v8.2.2.

@woshitoutouge
Copy link
Author

@tadashi-aikawa hi, I reinstall ob (v1.3.0), reinstall the plugin (v8.2.2), and record my screen.
I found when press Left key, Right key and End key, the popup box don't disappear, Home key i'm not sure.

video:
https://github.com/tadashi-aikawa/obsidian-various-complements-plugin/assets/99337435/9de98f8d-3d03-4390-8d24-a3ccccab4634

plugin setting:
2023-05-12_220014

@tadashi-aikawa
Copy link
Owner

@woshitoutouge
Thank you for your details :)

I could reproduce it. That should be a bug for Various Complements. If so, I'll fix it👍

@tadashi-aikawa
Copy link
Owner

@woshitoutouge
Fix in v8.2.3 🚀

@woshitoutouge
Copy link
Author

woshitoutouge commented May 13, 2023

@tadashi-aikawa That was fast! really appreciate your work!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Development

No branches or pull requests

2 participants