Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the build; modernize gemspec, more compatible Gemfile #408

Conversation

olleolleolle
Copy link
Contributor

@olleolleolle olleolleolle commented Apr 2, 2020

TL;DR: This PR fixes the build ✨

Link to passing build

Details

gemspec:

  • updated the gemspec ERB template
    • dropped unsupported & deprecated RubyGems settings
  • regenerated the gemspec
    • avoided changing the date
    • updated the list of test files, to match what is in the repo now

Bundler:

  • removed BUNDLED_WITH in lockfile,
  • hand-picked v1.17.3 for 2.2+ compatibility
  • Updated gems rake 13+ and test-unit to avoid warnings in ruby-head

CI:

Tests:


The warning in CI which made me look at the gemspec (which led to all this adventure!)

NOTE: Gem::Specification#has_rdoc= is deprecated with no replacement. It will be removed on or after 2018-12-01.

Gem::Specification#has_rdoc= called from /home/travis/build/taf2/curb/curb.gemspec:22.

The RubyGems gemspec property rubyforge_project has been removed without a replacement. This PR removes that property. RubyForge was closed down in 2013, rubygems/rubygems#2436 deprecated the rubyforge_project property.

  - regenerated the gemspec, avoided changing the date
  - this updated the list of test files, to match what is in the repo now
@olleolleolle olleolleolle changed the title Remove unsupported RubyGems properties gemspec: Remove unsupported RubyGems properties; fix the build Apr 2, 2020
@olleolleolle olleolleolle changed the title gemspec: Remove unsupported RubyGems properties; fix the build Fix the build; gemspec: Remove unsupported RubyGems properties Apr 2, 2020
@olleolleolle olleolleolle force-pushed the remove-unsupport-rubygems-properties branch from 1ad2bd8 to 69cf31c Compare April 2, 2020 13:22
@olleolleolle olleolleolle changed the title Fix the build; gemspec: Remove unsupported RubyGems properties Fix the build; modernize gemspec, more compatible Gemfile Apr 2, 2020
@olleolleolle olleolleolle force-pushed the remove-unsupport-rubygems-properties branch 2 times, most recently from 6f49ca2 to 30978a7 Compare April 2, 2020 15:36
  - this also removes the need for a specific install_if block in Gemfile
@olleolleolle olleolleolle force-pushed the remove-unsupport-rubygems-properties branch from 30978a7 to 9a57f0c Compare April 2, 2020 15:41
@olleolleolle
Copy link
Contributor Author

olleolleolle commented Apr 2, 2020

One of the effects of this PR was "fixes #405".

That makes this PR a partial duplicate of #406

(Worked that into the description field.)

  - this avoids warnings output on 2.7+
@olleolleolle
Copy link
Contributor Author

If you would like fewer commits, @taf2, I can rebase them in a shorter sequence.

@taf2
Copy link
Owner

taf2 commented Nov 3, 2020

Thanks merged!

@taf2 taf2 closed this Nov 3, 2020
@olleolleolle olleolleolle deleted the remove-unsupport-rubygems-properties branch November 3, 2020 15:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants