-
Notifications
You must be signed in to change notification settings - Fork 228
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix the build; modernize gemspec, more compatible Gemfile #408
Closed
olleolleolle
wants to merge
16
commits into
taf2:master
from
olleolleolle:remove-unsupport-rubygems-properties
Closed
Fix the build; modernize gemspec, more compatible Gemfile #408
olleolleolle
wants to merge
16
commits into
taf2:master
from
olleolleolle:remove-unsupport-rubygems-properties
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- regenerated the gemspec, avoided changing the date - this updated the list of test files, to match what is in the repo now
1ad2bd8
to
69cf31c
Compare
- to ensure it is there
- avoids warnings on Ruby 2.8
- it ought to have rubysl already in it
6f49ca2
to
30978a7
Compare
- this also removes the need for a specific install_if block in Gemfile
30978a7
to
9a57f0c
Compare
- this avoids warnings output on 2.7+
If you would like fewer commits, @taf2, I can rebase them in a shorter sequence. |
Thanks merged! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TL;DR: This PR fixes the build ✨
Link to passing build
Details
gemspec:
Bundler:
BUNDLED_WITH
in lockfile,rake
13+ andtest-unit
to avoid warnings inruby-head
CI:
dist: trusty
to make Rubinius even build; example of legitimate test failure in rbx-3,mixlib-shellout
usesMarshal.dump
/Marshal.load
Tests:
ruby-head
: made a space optional at the end of anassert_match
check (see same fix in Update tc_curl_easy.rb #406 and marked as a problem in unwanted space in tests/tc_curl_easy.rb? (line 24) #405)The warning in CI which made me look at the gemspec (which led to all this adventure!)
The RubyGems gemspec property
rubyforge_project
has been removed without a replacement. This PR removes that property. RubyForge was closed down in 2013, rubygems/rubygems#2436 deprecated therubyforge_project
property.