Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

timedelta and 1904 datetime system #324

Merged
merged 1 commit into from
Jun 13, 2023
Merged

Conversation

dimastbk
Copy link
Contributor

This PR add support timedelta and 1904 datetime system in excel files (partially closed #318).

For 1904 datetime system I'm using a hack like in #299 and I'm not sure that it's good. Maybe something like?

pub enum DataType {
    /// Date or Time, bool - is_1904
    DateTime(f64, bool),
}
 name        old ns/iter  new ns/iter  diff ns/iter  diff %  speedup 
 bench_ods   74,811       75,899              1,088   1.45%   x 0.99 
 bench_xls   32,367       32,154               -213  -0.66%   x 1.01 
 bench_xlsb  139,909      141,788             1,879   1.34%   x 0.99 
 bench_xlsx  197,789      196,129            -1,660  -0.84%   x 1.01

@dimastbk dimastbk marked this pull request as ready for review June 9, 2023 05:06
@tafia tafia merged commit 071c7ef into tafia:master Jun 13, 2023
@tafia
Copy link
Owner

tafia commented Jun 13, 2023

Thanks a lot one more time!

@dimastbk dimastbk deleted the timedelta-and-1904 branch June 13, 2023 04:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Datetime support
2 participants