Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove requirement to have Reader when decoding attributes and write anything converted to Event #760

Merged
merged 3 commits into from
Jun 23, 2024
Merged

Remove requirement to have Reader when decoding attributes and write anything converted to Event #760

merged 3 commits into from
Jun 23, 2024

Commits on Jun 23, 2024

  1. Remove unused import in doctest

    @Mingun
    Mingun committed Jun 23, 2024
    Configuration menu
    Copy the full SHA
    31ca532 View commit details
    Browse the repository at this point in the history

  2. Accept Decoder instead of Reader when decoding attributes. 

    This will allow decode them even if Reader does not exists, for example,
when you only write events.
    @Mingun
    Mingun committed Jun 23, 2024
    Configuration menu
    Copy the full SHA
    2553b62 View commit details
    Browse the repository at this point in the history

  3. Consume event when write. Use Event::borrow() if you want to keep o… 

    …wnership

This change will allow to feed to the writer different structs which, otherwise,
would be impossible if are not holds an `Event` inside your struct. In the future
the Event may be split into `reader::Event` and `writer::Event` and the reader
variant may evolve to be borrow-only.
    @Mingun
    Mingun committed Jun 23, 2024
    Configuration menu
    Copy the full SHA
    55f7aa1 View commit details
    Browse the repository at this point in the history