Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

async #13

Closed
wants to merge 6 commits into from
Closed

async #13

wants to merge 6 commits into from

Commits on May 17, 2020

  1. have a go at making goose async 

    It's a bit of a shitshow because of lifetimes, and the
fact that async functions can't be used as function
pointers (because the return value is not sized
predictably in a dynamic context).

This thread was really hepful to me:
https://users.rust-lang.org/t/how-to-store-async-function-pointer/38343/4

All that's left to do is:
* Fix the doctests
* Actually try out the examples and see if they are
  still working/performant.
* Go hunting for places where explicit threads are used
  which could be turned into tasks.
    @alsuren @jeremyandrews
    alsuren authored and jeremyandrews committed May 17, 2020
    Configuration menu
    Copy the full SHA
    c0f601f View commit details
    Browse the repository at this point in the history

  2. make it actually do something

    @alsuren @jeremyandrews
    alsuren authored and jeremyandrews committed May 17, 2020
    Configuration menu
    Copy the full SHA
    af84c48 View commit details
    Browse the repository at this point in the history

  3. another missing .await

    @alsuren @jeremyandrews
    alsuren authored and jeremyandrews committed May 17, 2020
    Configuration menu
    Copy the full SHA
    c93e5bd View commit details
    Browse the repository at this point in the history

  4. add mising await calls

    @jeremyandrews
    jeremyandrews committed May 17, 2020
    Configuration menu
    Copy the full SHA
    fb45da0 View commit details
    Browse the repository at this point in the history

  5. move async to launch_clients()

    @jeremyandrews
    jeremyandrews committed May 17, 2020
    Configuration menu
    Copy the full SHA
    c701860 View commit details
    Browse the repository at this point in the history

  6. when async lands goose will be 0.7.x

    @jeremyandrews
    jeremyandrews committed May 17, 2020
    Configuration menu
    Copy the full SHA
    98e73a5 View commit details
    Browse the repository at this point in the history