async #13
Closed
async #13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I spent some time trying to wrap |
jeremyandrews
commented
May 17, 2020
| @@ -16,6 +16,7 @@ license = "Apache-2.0" | |||
| ctrlc = "3.1" | |||
| http = "0.2" | |||
| log = "0.4" | |||
| macro_rules_attribute = "*" | |||
There was a problem hiding this comment.
@alsuren I'm hesitant to add this dependency. Perhaps instead we can implement this as a macro in goose_codegen, and generally add other macros in this dependency to improve goose ergonomics? (The code currently in there can be removed).
I don't like that it's a 0.0.1 release, that I don't see any other modules using it on crates.io, and that we have to invoke it before every load test function.
It's a bit of a shitshow because of lifetimes, and the fact that async functions can't be used as function pointers (because the return value is not sized predictably in a dynamic context). This thread was really hepful to me: https://users.rust-lang.org/t/how-to-store-async-function-pointer/38343/4 All that's left to do is: * Fix the doctests * Actually try out the examples and see if they are still working/performant. * Go hunting for places where explicit threads are used which could be turned into tasks.
|
Closing in favor of #22 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've rebased #8 onto latest
masterso we can continue this effort.