Convert to Async #22
Merged
Convert to Async #22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It's a bit of a shitshow because of lifetimes, and the fact that async functions can't be used as function pointers (because the return value is not sized predictably in a dynamic context). This thread was really hepful to me: https://users.rust-lang.org/t/how-to-store-async-function-pointer/38343/4 All that's left to do is: * Fix the doctests * Actually try out the examples and see if they are still working/performant. * Go hunting for places where explicit threads are used which could be turned into tasks.
Closed
alsuren
reviewed
May 23, 2020
alsuren
reviewed
May 23, 2020
This was referenced May 23, 2020
jeremyandrews
changed the title
|
@alsuren I've added a simple macro to remove the code-duplication required to wrap each task. I couldn't figure out how to put While it's not perfect, as it gives a 2x boost in performance I think this is usable/mergable. |
jeremyandrews
commented
May 24, 2020
jeremyandrews
commented
May 24, 2020
alsuren
reviewed
May 24, 2020
LionsAd
reviewed
May 24, 2020
LionsAd
approved these changes
May 24, 2020
LionsAd
reviewed
May 24, 2020
alsuren
reviewed
May 24, 2020
LionsAd
reviewed
May 24, 2020
LionsAd
reviewed
May 24, 2020
LionsAd
reviewed
May 24, 2020
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Re-implement async support without using
macro_rules_attributeWith help from this thread:
https://www.reddit.com/r/rust/comments/goh2be/how_to_store_an_async_future_to_a_function_with_a/