Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove dependency on num_cpus #543

Merged
merged 2 commits into from
May 10, 2023

Conversation

jeremyandrews
Copy link
Member

@jeremyandrews jeremyandrews commented May 1, 2023

  • remove external dependency on num_cpus(), use instead built-in available_parallelism() added in rust 1.59.0
  • we originally listed requiring a much earlier version of Rust, but Goose wasn't correctly compiling with such an old Rust; bumping up our dependency to something more modern (also required by the time library used by one or more dependencies)
  • closes remove dependency on num_cpus #542

@bebehei
Copy link

bebehei commented May 10, 2023

/ This might totally be unrelated, I'm new to the rust ecosystem /

I tried to build goose yesterday on NixOS and it already required rust version 1.65 because of the dependency on the time crate. See here:

bebe@gulasch:~/goose$ cargo build --example simple
    Updating crates.io index
  Downloaded rustls-pemfile v1.0.2
  Downloaded hyper-rustls v0.23.2
  Downloaded 2 crates (50.3 KB) in 0.77s
error: package `time v0.3.21` cannot be built because it requires rustc 1.65.0 or newer, while the currently active rustc version is 1.64.0

Wouldn't it be appropriate to even tag goose to have rustc version 1.65?

@jeremyandrews
Copy link
Member Author

Yes, that's an excellent point!

@jeremyandrews jeremyandrews merged commit 4dda2d0 into tag1consulting:main May 10, 2023
@jeremyandrews jeremyandrews deleted the parallelism branch May 10, 2023 09:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

remove dependency on num_cpus
2 participants