m4v

[asergunov]

adds support for m4v files

[scotchi]

In general I'm somewhat against this commit (though I'm no longer the taglib maintainer) since taglib in general doesn't, nor has it ever, supported video files and supporting them, even when trivial, seems out of scope for the library.

[lalinsky]

I'm against this change as well. There is a typo in the commit, it should have been m4v, not mpv, but as Scott mentioned, TagLib doesn't support video files and it's better if it stays that way. If you want, you can use the specific classes to open M4V files, but I'd rather FileRef to not do it. The files are typically much larger than audio files, users of the FileRef class might not be interested in them anyway.

[asergunov]

tag not in audio or in video. It's in container. tagLib has support of mp4
container. m4v is extension of file with mp4-organized video and audio
streams.

You already read tag from mp4 video file. What's wrong with m4v?

2011/7/29 lalinsky <
reply@reply.github.com>

I'm against this change as well. There is a typo in the commit, it should
have been m4v, not mpv, but as Scott mentioned, TagLib doesn't support video
files and it's better if it stays that way. If you want, you can use the
specific classes to open M4V files, but I'd rather FileRef to not do it. The
files are typically much larger than audio files, users of the FileRef class
might not be interested in them anyway.

Reply to this email directly or view it on GitHub:
#12 (comment)

[lalinsky]

Files with the .mp4 extension might be audio files, so it's safer to read them, but .m4v files are always videos. TagLib is used by applications that use it for reading audio files, reading video files is an unexpected behavior. It's the same for Windows Media Video, it would be trivial to add support to it, but I'd rather not.

[asergunov]

[sarcasm] so I can't find code to prevent read tag from .mp4 files with
(OMG) video inside [/sarcasm]

anyway LGPL says I need to publish patch and I did it.

2011/7/29 lalinsky <
reply@reply.github.com>

Files with the .mp4 extension might be audio files, so it's safer to read
them, but .m4v files are always videos. TagLib is used by applications that
use it for reading audio files, reading video files is an unexpected
behavior. It's the same for Windows Media Video, it would be trivial to add
support to it, but I'd rather not.

Reply to this email directly or view it on GitHub:
#12 (comment)