Some non-PCM wave files can cause SIG_ARITHMETIC #14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I've seen this in a wav that has an audio format of MP3 (0x55)
|
Would probably be nice to have such a wav file for testing... |
scotchi
added a commit
that referenced
this pull request
Jul 28, 2011
Some non-PCM wave files can cause SIG_ARITHMETIC
|
I couldn't add an attachment to this pull request but an example of such a file is http://dl.dropbox.com/u/21004626/peanuts_teacher.wav |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In a previous patch I submitted code to read the sample width and frame count for wav and aiff files. There was a bug in that code that leads to a crash on certain wav files. I've seen this in a wav that has an audio format of MP3 (0x55). Since the wav header indicates that the bit depth is 0 (compressed), a divide by zero error occurs when calculating the total audio frames. I've no idea why you would put MP3 data in a wav, but regardless, the code shouldn't crash.
I went ahead and added checks to the aiff code as well, although I haven't received any crash reports in the wild for those kind of files.