Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce ref/deref operations by introducing swap() functions. #433

Closed
wants to merge 1 commit into from
Closed

Reduce ref/deref operations by introducing swap() functions. #433

wants to merge 1 commit into from

Conversation

TsudaKageyu
Copy link
Contributor

Removed redundant ref/deref operations which make the memory management complicated from ByteVector, String, List and Map by introducing swap() functions.
Now, each class has only a pair of ref/deref except for ByteVector. ByteVector is a little more complicated due to the nested RefCounters should be fixed in another patch.

@lalinsky
Copy link
Member

lalinsky commented Dec 8, 2014

Did you measure the results in some way? Is there a benefit in doing this? I'd really like to focus more on tagging files and less on building a string/container library. Sorry, you have been spending a lot of time working on this part of TagLib and I feel it's getting a little too complicated, to justify being scraped and replaced by boost, if we need to continue extending it.

@TsudaKageyu TsudaKageyu closed this Jan 5, 2015
@TsudaKageyu TsudaKageyu deleted the swap branch January 6, 2015 03:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants