Calculate bitrate for ALAC files without it (#961) #981
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Again, on patches covering new territory, it's always good to have tests. |
If the "alac" atom of an MP4 file has a zero bitrate, it is calculated.
ufleisch
force-pushed
the
ufleisch/alac-without-bitrate
branch
from
d0d22be
to
3d71ea1
Compare
This incorporates [6ca536b] (mp4 properties: handle the case when mp4 file header has zero bitrate) from PR taglib#899 with a more accurate bitrate calculation and a unit test.
ufleisch
added a commit
to ufleisch/taglib
that referenced
this pull request
Dec 31, 2020
…rate Calculate bitrate for ALAC files without it (taglib#961)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the "alac" atom of an MP4 file has a zero bitrate, it is calculated.