-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
702.document snapshots #710
Conversation
Codecov Report
@@ Coverage Diff @@
## main #710 +/- ##
=======================================
Coverage 91.79% 91.79%
=======================================
Files 38 38
Lines 5144 5144
Branches 640 640
=======================================
Hits 4722 4722
Misses 277 277
Partials 145 145
Flags with carried forward coverage won't be shown. Click here to find out more. 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Note to self: the |
Besides the above tweak needed for the diagrams, I think this is ready for some Opinions if you have any @exarkun (you can see a rendered version of this branch by clicking through the "read the docs" check). |
4248711
to
5e6883f
Compare
I tried ensuring all the SVGs are "plain" (not "Inkscape") SVGs but github / firefox is still rendering the arrows w/o heads. That's the only gnit though; I'm going to merge this -- please file followup tickets if anything is missing or unclear :) |
:width: 100% | ||
:height: 30pt |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this on purpose? 30pt ~= 10,6 mm.
ReadTheDocs seems to only interpret the width (of 100%), the GitHub rendering only interprets the height (30pt, tiny).
Both keep the original aspect ratio - which is good - probably because one of width/height is a percentage?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(On my end, a height of 300pt looks good in GitHub)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixes #702