Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove _get_json_for_fragment() from cli #90

Merged
merged 2 commits into from
May 5, 2020
Merged

Conversation

vu3rdd
Copy link
Member

@vu3rdd vu3rdd commented Apr 17, 2020

Integration test use _get_json_for_fragment(), so this has been modified to use the new status API.

@vu3rdd vu3rdd requested review from meejah and exarkun April 17, 2020 11:44
@meejah
Copy link
Collaborator

meejah commented Apr 17, 2020

Hmm, does this mean the new status API doesn't need a token??

@vu3rdd
Copy link
Member Author

vu3rdd commented Apr 17, 2020

Hmm, does this mean the new status API doesn't need a token??

It is being accessed inside the status() function, it looks like: https://github.com/LeastAuthority/magic-folder/blob/master/src/magic_folder/status.py#L71

@meejah
Copy link
Collaborator

meejah commented Apr 17, 2020

Ahhh I see. Sorry, read it too fast :)

Copy link
Collaborator

@meejah meejah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

once it passes CI, LGTM

@vu3rdd
Copy link
Member Author

vu3rdd commented Apr 17, 2020

Thanks. I will keep it open for now until #87 is in and after that will do a CI run and then merge once it is all green.

@codecov
Copy link

codecov bot commented May 5, 2020

Codecov Report

Merging #90 into master will increase coverage by 0.68%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #90      +/-   ##
==========================================
+ Coverage   85.70%   86.39%   +0.68%     
==========================================
  Files          17       17              
  Lines        2106     2080      -26     
  Branches      279      273       -6     
==========================================
- Hits         1805     1797       -8     
+ Misses        235      216      -19     
- Partials       66       67       +1     
Flag Coverage Δ
#integration 32.35% <ø> (+0.11%) ⬆️
Impacted Files Coverage Δ
src/magic_folder/cli.py 80.00% <ø> (+2.86%) ⬆️
src/magic_folder/magic_folder.py 90.66% <0.00%> (-0.35%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8af89f0...5ed7c90. Read the comment docs.

@vu3rdd vu3rdd merged commit e8bc7b2 into master May 5, 2020
@vu3rdd vu3rdd deleted the 89.remove-dead-code branch May 5, 2020 04:06
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants