-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
remove _get_json_for_fragment() from cli #90
Conversation
Hmm, does this mean the new status API doesn't need a token?? |
It is being accessed inside the |
Ahhh I see. Sorry, read it too fast :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
once it passes CI, LGTM
Thanks. I will keep it open for now until #87 is in and after that will do a CI run and then merge once it is all green. |
d5cb307
to
ebbde61
Compare
Codecov Report
@@ Coverage Diff @@
## master #90 +/- ##
==========================================
+ Coverage 85.70% 86.39% +0.68%
==========================================
Files 17 17
Lines 2106 2080 -26
Branches 279 273 -6
==========================================
- Hits 1805 1797 -8
+ Misses 235 216 -19
- Partials 66 67 +1
Continue to review full report at Codecov.
|
Integration test use
_get_json_for_fragment()
, so this has been modified to use the new status API.