Skip to content

Commit

Permalink
On Windows, exclude versions of Twisted that have endpoints and there…
Browse files Browse the repository at this point in the history
…fore depend on pywin32.

Signed-off-by: Daira Hopwood <daira@jacaranda.org>
  • Loading branch information
daira committed Feb 21, 2014
1 parent e1840f1 commit d888b28
Showing 1 changed file with 18 additions and 13 deletions.
31 changes: 18 additions & 13 deletions src/allmydata/_auto_deps.py
Original file line number Diff line number Diff line change
Expand Up @@ -18,19 +18,6 @@
# zope.interface 3.6.3 and 3.6.4 are incompatible with Nevow (#1435).
"zope.interface == 3.6.0, == 3.6.1, == 3.6.2, >= 3.6.5",

# * On Windows we need at least Twisted 9.0 to avoid an indirect
# dependency on pywin32.
# * On Linux we need at least Twisted 10.1.0 for inotify support used by
# the drop-upload frontend.
# * We also need Twisted 10.1 for the FTP frontend in order for Twisted's
# FTP server to support asynchronous close.
# * When the cloud backend lands, it will depend on Twisted 10.2.0 which
# includes the fix to https://twistedmatrix.com/trac/ticket/411
# * The SFTP frontend depends on Twisted 11.0.0 to fix the SSH server
# rekeying bug http://twistedmatrix.com/trac/ticket/4395
#
"Twisted >= 11.0.0",

# * foolscap < 0.5.1 had a performance bug which spent O(N**2) CPU for
# transferring large mutable files of size N.
# * foolscap < 0.6 is incompatible with Twisted 10.2.0.
Expand Down Expand Up @@ -90,6 +77,24 @@
def require_more():
import sys

# * On Windows we need at least Twisted 9.0 to avoid an indirect
# dependency on pywin32.
# * On Linux we need at least Twisted 10.1.0 for inotify support used by
# the drop-upload frontend.
# * We also need Twisted 10.1 for the FTP frontend in order for Twisted's
# FTP server to support asynchronous close.
# * When the cloud backend lands, it will depend on Twisted 10.2.0 which
# includes the fix to https://twistedmatrix.com/trac/ticket/411
# * The SFTP frontend depends on Twisted 11.0.0 to fix the SSH server
# rekeying bug http://twistedmatrix.com/trac/ticket/4395
#
if sys.platform in ("win32", "cygwin"):
# * On Windows we can't use Twisted 12.2.0 or later (yet) because the
# endpoints code depends on pywin32. http://twistedmatrix.com/trac/ticket/6032
install_requires += ["Twisted == 11.0.0, == 11.1.0, == 12.0.0, == 12.1.0"]
else:
install_requires += ["Twisted >= 11.0.0"]

# Don't try to get the version number of setuptools in frozen builds, because
# that triggers 'site' processing that causes failures. Note that frozen
# builds still (unfortunately) import pkg_resources in .tac files, so the
Expand Down

5 comments on commit d888b28

@zooko
Copy link
Member

@zooko zooko commented on d888b28 May 26, 2014

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@zooko
Copy link
Member

@zooko zooko commented on d888b28 May 26, 2014

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh no I take that +1 back. Let's remove the comments explaining about requirements on earlier Twisteds than our hard requirement on 11.0.0. After That then I give this +1.

@daira
Copy link
Member Author

@daira daira commented on d888b28 May 28, 2014

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why remove those comments? They're useful information justifying the choice of requirement, no?

If we do remove them, at least we should do so consistently for all dependencies.

@zooko
Copy link
Member

@zooko zooko commented on d888b28 May 28, 2014

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Those comments are only useful for archaeological purposes, right? Since we require Twisted ≥ 11.0.0 (for the ssh server rekeying bug), then it doesn't currently matter that we used to require Twisted ≥ 10.1 (for asynchronous close), or that we would require Twisted ≥ 10.2.0 for https://twistedmatrix.com/trac/ticket/411.

@daira
Copy link
Member Author

@daira daira commented on d888b28 May 29, 2014

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well, that depends on whether we think it's important to know all the reasons why we require the version we do, rather than just some of the reasons.

Please sign in to comment.