-
Notifications
You must be signed in to change notification settings - Fork 246
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
On Windows, exclude versions of Twisted that have endpoints and there…
…fore depend on pywin32. Signed-off-by: Daira Hopwood <daira@jacaranda.org>
- Loading branch information
Showing
1 changed file
with
18 additions
and
13 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
d888b28
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1
d888b28
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh no I take that +1 back. Let's remove the comments explaining about requirements on earlier Twisteds than our hard requirement on 11.0.0. After That then I give this +1.
d888b28
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why remove those comments? They're useful information justifying the choice of requirement, no?
If we do remove them, at least we should do so consistently for all dependencies.
d888b28
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Those comments are only useful for archaeological purposes, right? Since we require Twisted ≥ 11.0.0 (for the ssh server rekeying bug), then it doesn't currently matter that we used to require Twisted ≥ 10.1 (for asynchronous close), or that we would require Twisted ≥ 10.2.0 for https://twistedmatrix.com/trac/ticket/411.
d888b28
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well, that depends on whether we think it's important to know all the reasons why we require the version we do, rather than just some of the reasons.