Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2235 long paths on windows 1 #100

Closed
wants to merge 5 commits into from
Closed

Conversation

daira
Copy link
Member

@daira daira commented Aug 19, 2014

Support long (> 269 UTF-16 code unit) paths on Windows.

Signed-off-by: Daira Hopwood <daira@jacaranda.org>
…nd other obscure path types on Windows. refs #2235

Signed-off-by: Daira Hopwood <daira@jacaranda.org>
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
@zooko
Copy link
Member

zooko commented Aug 21, 2014

Daira: want to fix the formatting detail (an extra space in a string slice) or just click "Merge pull request" now? :-)

@daira daira mentioned this pull request Aug 21, 2014
@daira
Copy link
Member Author

daira commented Aug 21, 2014

Please hold off merging this; there are instances of os.path.abspath and os.path.expanduser that don't go through fileutil.abspath_expanduser_unicode and should be changed to do so. That includes the call in fileutil.put_file that motivated ticket 2235, so this pull request doesn't actually fix the bug. See the results of egrep -Rn --include='*.py' 'expanduser|abspath' src |egrep -v 'abspath_expanduser_unicode|argv_to_abspath' for other cases.

I've closed the pull request to stop it being merged accidentally.

@daira daira closed this Aug 21, 2014
@zooko
Copy link
Member

zooko commented Aug 21, 2014

I've finished reviewing it! I didn't notice the extra expanduser's and abspath's.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants