Run (and pass) Python 3 unit tests on Windows #1067
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The failing 3.9 is due to |
…uires compilation which fails, sticking to 3.7 is workaround since it has Windows wheels.
meejah
approved these changes
May 26, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes https://tahoe-lafs.org/trac/tahoe-lafs/ticket/3700
Fixes https://tahoe-lafs.org/trac/tahoe-lafs/ticket/3701
Integration tests will be follow-up ticket.
Changes that merit extra attention: on Python 3, I disabled the various Unicode-specific "fixes". This changes behavior slightly, but my presumption that Python 3's built-in Unicode functionality is probably better than what this code does. The mentioned bugs were fixed in Python 3, I believe.