3757 : Refactored test_introducer in web tests

[Fenn-CS]

Refactored test_introducer.py in test/web module to either user SyncTestCase or AsyncTestCase.

Ticket : https://tahoe-lafs.org/trac/tahoe-lafs/ticket/3757

[exarkun]

Thanks. I left some commentary inline. This looks like a good start.

[meejah]

Looking really good!

I'm not asking for changes here, but especially for shorter tests like this one I think we (or at least "I") have been indenting things like this:

self.assertThat(
    render(resource, {b"t": [b"json"]}),
    succeeded(
        AfterPreprocessing(
            json.loads,
            Equals({
                u"subscription_summary": {"arbitrary": 2},
                u"announcement_summary": {"arbitrary": 1},
            })
        )
    )
)

I'm actually curious if you think that counts as "readable", or if it's just because I'm now used to it ;)

If nothing else, I do like:

self.assertThat(
    <something>,
    CollectionOfMatchers(),
)

...to separate the "test thing" (<something>) from the "expected results part" (i.e. all the testtools matchers). I do think it took me a while to get around the "matcher" style of test-tools, but it can be fairly readable (even if the writing can be a little harder, due to having to look up matchers).

p.s. I know I said "approve" but maybe @exarkun wishes to followup .. and CI has to be green before we merge things...

[Fenn-CS]

@meejah Yeah, I think that's more readable. I ran the linting I found the tox config to see if would complain or refactor that, did not! Could quickly push a new commit with that. If we would use it in other places we might as well just do it here.

EDIT : It's worth noting that I think the use of expected and response make it the code more readable, but also spreading it over a few lines is a good idea. So a kind of a mix.

[coveralls]

Coverage increased (+0.02%) to 95.474% when pulling b5c3290 on Fenn-CS:3757.refactor.web-test-introducer into 22622b5 on tahoe-lafs:master.

[May-Lee]

@exarkun could you approve requested changes and merge when ready please?