Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release 1.16.0 - Python 3 & Python 2 Support #1128

Closed
wants to merge 7 commits into from

Conversation

Fenn-CS
Copy link
Collaborator

@Fenn-CS Fenn-CS commented Sep 16, 2021

First Tahoe release with support for Python 3 and Python 2 which would be dropped in a future version.

Closes: https://tahoe-lafs.org/trac/tahoe-lafs/ticket/3754

@wearpants
Copy link

wearpants commented Sep 16, 2021 via email

Signed-off-by: fenn-cs <fenn25.fn@gmail.com>
Signed-off-by: fenn-cs <fenn25.fn@gmail.com>
Signed-off-by: fenn-cs <fenn25.fn@gmail.com>
Signed-off-by: fenn-cs <fenn25.fn@gmail.com>
Signed-off-by: fenn-cs <fenn25.fn@gmail.com>
Signed-off-by: fenn-cs <fenn25.fn@gmail.com>
@Fenn-CS
Copy link
Collaborator Author

Fenn-CS commented Sep 16, 2021

Forced push before review, due to repeating commits after accidentally running tox -e news 3 times thereby having "update news for release" committed thrice.

@coveralls
Copy link
Collaborator

coveralls commented Sep 16, 2021

Coverage Status

Coverage decreased (-0.007%) to 95.49% when pulling e272b15 on Fenn-CS:3754.release-1.16.0 into 9c7d719 on tahoe-lafs:master.

@meejah
Copy link
Contributor

meejah commented Sep 16, 2021

This is definitely good practice for a "proper" release, but in this particular case maybe we should have started from the 1.16.0-rc0 branch (and just merged in the one blocker discovered)?

I suppose either way is fine, but if we proceed with this branch I think it should probably be -rc1 first since it includes other changes on master (right?)

@Fenn-CS
Copy link
Collaborator Author

Fenn-CS commented Sep 16, 2021

Yes it includes other changes from master.
Actually, I did ask in the IRC if you wanted me to continue from that last release candidate PR, looks like you missed that.

@meejah
Copy link
Contributor

meejah commented Sep 17, 2021

Actually, I did ask in the IRC if you wanted me to continue from that last release candidate PR, looks like you missed that.

Sorry about that!
Maybe lets carry this through as rc1 and then release it, if that sounds good?
We probably don't need to wait very long between rc1 and "the release" since only a few things are added.

@Fenn-CS
Copy link
Collaborator Author

Fenn-CS commented Sep 17, 2021

okay

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants