Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A start at a HTTP-based storage server and client #1161

Merged
merged 29 commits into from Dec 1, 2021

Conversation

itamarst
Copy link
Collaborator

@itamarst itamarst commented Nov 16, 2021

Fixes https://tahoe-lafs.org/trac/tahoe-lafs/ticket/3843
Fixes https://tahoe-lafs.org/trac/tahoe-lafs/ticket/3762 (basically "we return the same thing as Foolscap").

@coveralls
Copy link
Collaborator

coveralls commented Nov 16, 2021

Coverage Status

Coverage increased (+0.03%) to 95.701% when pulling 8cf11c9 on 3843-start-http-storage-server into fe6a2f6 on master.

Copy link
Contributor

@meejah meejah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good so far, some inline comments

@@ -95,7 +95,7 @@ EOF
propagatedBuildInputs = with python.pkgs; [
twisted foolscap zfec appdirs
setuptoolsTrial pyasn1 zope_interface
service-identity pyyaml magic-wormhole treq
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this why nixos is failing? (we still use treq right?)

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, it's missing different things in 19.whatever and 20.whatever. Maybe we can drop the former...

src/allmydata/storage/http_client.py Show resolved Hide resolved
src/allmydata/storage/http_server.py Show resolved Hide resolved
src/allmydata/storage/http_server.py Outdated Show resolved Hide resolved
nix/cbor2.nix Outdated Show resolved Hide resolved
itamarst and others added 3 commits December 1, 2021 09:24
Co-authored-by: Jean-Paul Calderone <exarkun@twistedmatrix.com>
…s/tahoe-lafs into 3843-start-http-storage-server
@itamarst itamarst merged commit f7975b9 into master Dec 1, 2021
@itamarst itamarst deleted the 3843-start-http-storage-server branch December 1, 2021 15:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants