Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

A variety of CPU and memory resource limits for the HTTP storage client and server #1203

Merged
merged 22 commits into from Jul 15, 2022
Merged

A variety of CPU and memory resource limits for the HTTP storage client and server #1203

merged 22 commits into from Jul 15, 2022

Conversation

itamarst
Copy link
Collaborator

@itamarst itamarst requested a review from a team June 30, 2022 17:56
exarkun
exarkun reviewed Jun 30, 2022
View reviewed changes
Copy link
Member

@exarkun exarkun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. Only got through part of this today but I left some comments inline for that. I'll finish tomorrow morning.

src/allmydata/test/test_storage_http.py Outdated Show resolved Hide resolved
src/allmydata/test/test_storage_http.py Outdated Show resolved Hide resolved
src/allmydata/storage/http_server.py Outdated Show resolved Hide resolved
src/allmydata/storage/http_server.py Outdated Show resolved Hide resolved
src/allmydata/storage/http_server.py Outdated Show resolved Hide resolved
src/allmydata/storage/http_server.py Outdated Show resolved Hide resolved
exarkun
exarkun requested changes Jul 1, 2022
View reviewed changes
Copy link
Member

@exarkun exarkun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! A few more inline comments. I guess there's enough that I'd like to take another look once those are addressed.

src/allmydata/storage/http_client.py Outdated Show resolved Hide resolved
src/allmydata/storage/http_client.py Show resolved Hide resolved
src/allmydata/storage/http_client.py Show resolved Hide resolved
src/allmydata/storage/http_client.py Outdated Show resolved Hide resolved
src/allmydata/storage/http_server.py Show resolved Hide resolved
@coveralls
Copy link
Collaborator

coveralls commented Jul 5, 2022 •
edited

Coverage Status

Coverage decreased (-0.02%) to 94.727% when pulling a24aefa on 3872-resource-limits-http-storage into a78f504 on master.

@itamarst
Copy link
Collaborator Author

itamarst commented Jul 6, 2022

OK I believe I have either addressed all issues, explained why it's not solvable, or opened follow-up issue in one case.

@itamarst itamarst requested a review from exarkun July 6, 2022 14:02
exarkun
exarkun approved these changes Jul 12, 2022
View reviewed changes
Copy link
Member

@exarkun exarkun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! This looks good. Just a couple minor points inline (one accidentally detached from this review). Please do with those what you will and then merge.

src/allmydata/storage/http_client.py Show resolved Hide resolved
@itamarst itamarst merged commit 69f90e6 into master Jul 15, 2022
@itamarst itamarst deleted the 3872-resource-limits-http-storage branch July 15, 2022 16:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@exarkun exarkun exarkun approved these changes

Assignees
No one assigned
Labels
HTTP Storage Protocol
Projects
None yet
Milestone
No milestone
4 participants
@itamarst @coveralls @exarkun @pythonspeed