Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

attrs "provides()" #1326

Merged
merged 6 commits into from Aug 9, 2023
Merged

attrs "provides()" #1326

merged 6 commits into from Aug 9, 2023

Conversation

meejah
Copy link
Contributor

@meejah meejah commented Aug 2, 2023 •
edited

Fixes ticket #4056

(Note this is stacked on #1208 so most of the changes will "vanish" once that is merged and this PR is updated).

exarkun
exarkun approved these changes Aug 7, 2023
View reviewed changes
Copy link
Member

@exarkun exarkun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. A couple inline comments. Please address those and if CI is green (currently it is very red) then merge.

src/allmydata/storage_client.py Outdated Show resolved Hide resolved
integration/grid.py Outdated Show resolved Hide resolved
@coveralls
Copy link
Collaborator

Coverage Status

coverage: 94.652% (+0.1%) from 94.544% when pulling d3d57a6 on 4056.provides into c2b4ceb on master.

@meejah meejah merged commit d0e1d8e into master Aug 9, 2023
30 checks passed
@meejah meejah deleted the 4056.provides branch August 9, 2023 23:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@exarkun exarkun exarkun approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@meejah @coveralls @exarkun