Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Python 3.12 support, compatability with Eliot 1.15 #1344

Merged
merged 34 commits into from
Nov 21, 2023
Merged

Python 3.12 support, compatability with Eliot 1.15 #1344

merged 34 commits into from
Nov 21, 2023

Conversation

itamarst
Copy link
Collaborator

@itamarst itamarst commented Nov 16, 2023 •
edited
Loading

Fixes https://tahoe-lafs.org/trac/tahoe-lafs/ticket/4071 (not sure where 3072 in branch name came from)

  • Tests pass
  • Tests run on 3.12 on Windows. I chose to use GitHub because CircleCI don't bother documenting what versions of Python they have on their image, and since it's so new I don't have a lot of confidence they've added it, so don't want to waste time on it this week.

@coveralls
Copy link
Collaborator

coveralls commented Nov 16, 2023 •
edited
Loading

Coverage Status

coverage: 94.765% (+0.2%) from 94.595%
when pulling 5dfc39c on 3072-python-3.12-support
into c98be85 on master.

@itamarst itamarst marked this pull request as draft November 17, 2023 16:32
@itamarst itamarst mentioned this pull request Nov 20, 2023
Closed
@itamarst itamarst marked this pull request as ready for review November 20, 2023 14:39
@itamarst itamarst changed the base branch from master to 517.add-client-plugin-config.1 November 20, 2023 14:42
@itamarst itamarst changed the base branch from 517.add-client-plugin-config.1 to master November 20, 2023 14:42
meejah
meejah approved these changes Nov 20, 2023
View reviewed changes
Copy link
Contributor

@meejah meejah left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, like less code!
(Some inline comments, optional)

src/allmydata/immutable/upload.py Show resolved Hide resolved
src/allmydata/test/test_storage_http.py Show resolved Hide resolved
@itamarst itamarst merged commit e3c8ff0 into master Nov 21, 2023
31 checks passed
@itamarst itamarst deleted the 3072-python-3.12-support branch November 21, 2023 13:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@meejah meejah meejah approved these changes

Assignees
No one assigned
Labels
Benchmarking and Performance
Projects
None yet
Milestone
No milestone
4 participants
@itamarst @coveralls @meejah @pythonspeed