2406.otf objective 2.1 bugfixes 1 #153
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- remove filepath from pending upload set BEFORE performing upload This bug was introduced at commit 87657eb
If using a bounded deque then: """ Once a bounded length deque is full, when new items are added, a corresponding number of items are discarded from the opposite end. """ This bug was introduced at commit 87657eb
|
ok... i'll look at moving the call to .remove()... |
|
problems fixed in recent commits to this same branch. perhaps i need to submit another pull request for Travis CI to test with the new changes? anyhow it now passes all unit tests and i put the .remove() earlier like you suggest. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
a few bug fixes