Mock out _turn_deque on MagicFolders during tests #191
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of using a Clock instance to drive the tests forward faster, we mock out the _turn_deque calls in MagicFolder and use the originals to drive forward the download/upload queue as required by the tests. Conflicts: src/allmydata/test/test_magic_folder.py
|
Reviewing. |
|
-1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of using a Clock instance to drive the tests forward faster, we mock out the _turn_deque calls in MagicFolder and use the originals to drive forward the download/upload queue as required by the tests.
Curious what you think of this approach? (And: why don't we need a ._bob_download() where the XXX comment is?) Tests go from ~70s to ~7s on my machine.