New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make travis test on osx and linux both #285
Conversation
script: | ||
- tox -e coverage | ||
- if [ "${TRAVIS_OS_NAME}" = "linux" ]; then sudo tox -e coverage; fi | ||
- if [ "${TRAVIS_OS_NAME}" = "osx" ]; then tox -e coverage; fi | ||
after_success: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we shouldn't need "sudo tox ..." for linux ... but even if it has to stay, it's not our infrastructure so ¯_(ツ)_/¯
Eww. Yeah, maybe that's the only way to do it, but.. hrm. I'm guessing the sudo has to do with magic-folders wanting to do something with inotify? But.. wait, no, if sudo is necessary to test magic-folders, then non-root users can't test magic-folders, which doesn't sound ok to me. What's the motivation for this? Also:
|
@warner ok with those recent changes from your review the tests pass in linux but fail for osx with:
|
I figured out how to make this work. I believe the OpenSSL complaint happened because I changed .travis.yml to use system python on OS-X (not homebrew), which arguably gives us more "natural" test coverage (I use homebrew python personally, but it'd be great to test on a vanilla OS-X platform). As a result, it has to install The biggest change was to use the I'll land the new branch (which includes your commits, rebased to current master) in a minute. |
No description provided.