2829.polling interval.5 #371
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This forces the Uploader and Downloader to implement a _scan_delay method and makes the naming more consistent with what's actually happening. Also, fix a few "bugs" in the names of args in the mocks for some tests.
Current coverage is 89.77% (diff: 76.19%)@@ master #371 diff @@
==========================================
Files 135 135
Lines 26813 26808 -5
Methods 0 0
Messages 0 0
Branches 3739 3738 -1
==========================================
Hits 24068 24068
+ Misses 2038 2037 -1
+ Partials 707 703 -4
|
|
looks good to me! |
|
Sounds good. Wanna update the docs to mention the new config knob? Landing (in rebased form) momentarily. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here's a stab at adding a "poll_interval" option for magic-folder (for the downloader poll interval) and some refactoring to make the names etc better in the code.