Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

simplejson -> json #405

Merged
merged 1 commit into from
Mar 24, 2017
Merged

Conversation

meejah
Copy link
Contributor

@meejah meejah commented Feb 23, 2017

I believe we discussed this at one nuts-and-bolts? I found this branch and it looks plausible (replacing all use of simplejson with the built-in json module).

@codecov-io
Copy link

Codecov Report

Merging #405 into master will increase coverage by 0.04%.
The diff coverage is 95.45%.

@@            Coverage Diff             @@
##           master     #405      +/-   ##
==========================================
+ Coverage   87.96%   88.01%   +0.04%     
==========================================
  Files         145      145              
  Lines       27439    27439              
  Branches     3805     3805              
==========================================
+ Hits        24138    24150      +12     
+ Misses       2600     2590      -10     
+ Partials      701      699       -2
Impacted Files Coverage Δ
src/allmydata/_auto_deps.py 91.66% <ø> (ø)
src/allmydata/web/filenode.py 93.93% <100%> (ø)
src/allmydata/web/introweb.py 100% <100%> (ø)
src/allmydata/scripts/tahoe_ls.py 83.76% <100%> (ø)
src/allmydata/web/directory.py 93.43% <100%> (-0.01%)
src/allmydata/scripts/tahoe_manifest.py 90% <100%> (ø)
src/allmydata/scripts/tahoe_check.py 80.91% <100%> (ø)
src/allmydata/scripts/slow_operation.py 66.17% <100%> (ø)
src/allmydata/web/status.py 83.14% <100%> (ø)
src/allmydata/web/storage.py 96.77% <100%> (ø)
... and 14 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bb782b0...031a88c. Read the comment docs.

@warner
Copy link
Member

warner commented Mar 24, 2017

awesome, landing with a few comment updates

@warner warner merged commit 031a88c into tahoe-lafs:master Mar 24, 2017
@meejah meejah deleted the use-json-not-simplejson branch March 20, 2018 22:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants