Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use @implementer instead of implements #406

Merged
merged 1 commit into from
Mar 24, 2017

Conversation

meejah
Copy link
Contributor

@meejah meejah commented Feb 27, 2017

Also, derive some more things from 'object'

Also, derive some more things from 'object'
@codecov-io
Copy link

Codecov Report

Merging #406 into master will decrease coverage by -0.02%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master     #406      +/-   ##
==========================================
- Coverage   87.96%   87.95%   -0.02%     
==========================================
  Files         145      145              
  Lines       27439    27439              
  Branches     3805     3898      +93     
==========================================
- Hits        24138    24135       -3     
- Misses       2600     2602       +2     
- Partials      701      702       +1
Impacted Files Coverage Δ
src/allmydata/immutable/repairer.py 100% <100%> (ø)
src/allmydata/immutable/offloaded.py 92.85% <100%> (ø)
src/allmydata/frontends/auth.py 59.59% <100%> (ø)
src/allmydata/client.py 86.95% <100%> (ø)
src/allmydata/monitor.py 100% <100%> (ø)
src/allmydata/immutable/upload.py 96.34% <100%> (ø)
src/allmydata/immutable/filenode.py 95.91% <100%> (ø)
src/allmydata/dirnode.py 98.26% <100%> (ø)
src/allmydata/web/directory.py 93.44% <100%> (ø)
src/allmydata/frontends/sftpd.py 91.43% <100%> (ø)
... and 33 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bb782b0...49ae2c5. Read the comment docs.

@warner
Copy link
Member

warner commented Mar 24, 2017

Looks good. I see several classes that got updated to new-style.. that's good too. The only one that I think we can't update is HelperUploadResults, because it's also pb.Copyable, and foolscap doesn't handle new-style classes yet (despite them being around for ages).

Landing momentarily.

@warner warner merged commit 49ae2c5 into tahoe-lafs:master Mar 24, 2017
@warner
Copy link
Member

warner commented Mar 24, 2017

Oh, I should have added a commit comment, but this also closes ticket 2636 (https://tahoe-lafs.org/trac/tahoe-lafs/ticket/2636).

@meejah meejah deleted the implements-to-implementer branch March 20, 2018 22:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants