Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

magic-folder: change stopService to call MultiService.stopService #407

Closed

Conversation

david415
Copy link
Member

@david415 david415 commented Mar 3, 2017

No description provided.

@codecov-io
Copy link

Codecov Report

Merging #407 into master will increase coverage by 0.01%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master     #407      +/-   ##
==========================================
+ Coverage   87.96%   87.98%   +0.01%     
==========================================
  Files         145      145              
  Lines       27439    27439              
  Branches     3805     3805              
==========================================
+ Hits        24138    24143       +5     
+ Misses       2600     2595       -5     
  Partials      701      701
Impacted Files Coverage Δ
src/allmydata/frontends/magic_folder.py 83.85% <100%> (ø)
src/allmydata/immutable/upload.py 96.24% <0%> (-0.1%)
src/allmydata/immutable/checker.py 87.94% <0%> (+0.25%)
src/allmydata/mutable/servermap.py 94.2% <0%> (+0.32%)
src/allmydata/util/dictutil.py 97.89% <0%> (+0.7%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bb782b0...6426da0. Read the comment docs.

@meejah
Copy link
Contributor

meejah commented Mar 13, 2017

👍 looks good to me!

@david415
Copy link
Member Author

i'm a simple one line patch, merge me?

@warner
Copy link
Member

warner commented Apr 10, 2017

Landing (rebased) in 0599adf. One thing to consider, that gatherResults means the child Services and MagicFolder.finish will run in parallel. If there's any reason why you need finish to finish before the children are told to stop (or vice versa), you should turn that into a sequential flow (probably with inlineCallbacks).

@warner warner closed this in 0599adf Apr 10, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants