Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

explicit Python 2.7 virtualenv #410

Closed
wants to merge 1 commit into from

Conversation

tpltnt
Copy link
Contributor

@tpltnt tpltnt commented Apr 6, 2017

Hi there,

I added Python 2.7 as an explicit option to the virtualenv command. I tripped over it and ended up with a non 2.7 version which resulted in more issues down the road.

Cheers,
tpltnt

@codecov-io
Copy link

Codecov Report

Merging #410 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #410   +/-   ##
=======================================
  Coverage   88.02%   88.02%           
=======================================
  Files         146      146           
  Lines       27577    27577           
  Branches     3921     3921           
=======================================
  Hits        24276    24276           
- Misses       2594     2598    +4     
+ Partials      707      703    -4
Impacted Files Coverage Δ
src/allmydata/web/status.py 83.27% <0%> (-0.12%) ⬇️
src/allmydata/util/encodingutil.py 87.95% <0%> (ø) ⬆️
src/allmydata/windows/fixups.py 0% <0%> (ø) ⬆️
src/allmydata/windows/inotify.py 0% <0%> (ø) ⬆️
src/allmydata/mutable/servermap.py 94.2% <0%> (+0.16%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4f1dd95...8a1b9de. Read the comment docs.

@warner
Copy link
Member

warner commented Apr 10, 2017

looks good, landing (rebased) in bfae038

@warner warner closed this in bfae038 Apr 10, 2017
@tpltnt tpltnt deleted the py27-venv-hint branch April 11, 2017 10:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants