Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add libyaml-dev dependency #420

Closed
wants to merge 1 commit into from
Closed

Add libyaml-dev dependency #420

wants to merge 1 commit into from

Conversation

ValdikSS
Copy link
Contributor

@ValdikSS ValdikSS commented Jun 5, 2017

No description provided.

@codecov-io
Copy link

codecov-io commented Jun 5, 2017

Codecov Report

Merging #420 into master will decrease coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #420      +/-   ##
==========================================
- Coverage   88.02%   88.01%   -0.02%     
==========================================
  Files         146      146              
  Lines       27578    27578              
  Branches     3921     3921              
==========================================
- Hits        24275    24272       -3     
- Misses       2599     2601       +2     
- Partials      704      705       +1
Impacted Files Coverage Δ
src/allmydata/mutable/servermap.py 93.55% <0%> (-0.65%) ⬇️
src/allmydata/web/status.py 83.16% <0%> (-0.23%) ⬇️
src/allmydata/immutable/layout.py 90.55% <0%> (ø) ⬆️
src/allmydata/immutable/upload.py 96.34% <0%> (+0.09%) ⬆️
src/allmydata/stats.py 86.2% <0%> (+0.86%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 42d8a79...b079191. Read the comment docs.

@warner
Copy link
Member

warner commented Jun 6, 2017

cool, thanks. I'll land this (in rebased form) in a moment. It's a pity this is necessary.. it'd be nice if there were a way to make PyYAML use the pure-python implementation (instead of linking against a C library), especially since we don't really need it to be fast. But if PyYAML decides to use libyaml, for whatever reason, then you're right we need the development headers to be installed.

@warner warner closed this in 958f79d Jun 6, 2017
@ValdikSS
Copy link
Contributor Author

ValdikSS commented Jun 6, 2017

Please wait a moment, it could be my fault. I'll recheck it in some hours if it's really needed. It could be that pip failed to install python version of yaml.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants