2857 deprecations #428
Merged
2857 deprecations #428
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
warner
force-pushed
the
2857-deprecations
branch
from
b433edf
to
71c6649
Compare
Codecov Report
@@ Coverage Diff @@
## master #428 +/- ##
=======================================
Coverage 87.99% 87.99%
=======================================
Files 147 147
Lines 27836 27836
Branches 3974 3974
=======================================
Hits 24495 24495
Misses 2624 2624
Partials 717 717
Continue to review full report at Codecov.
|
This also changes the tests to handle the new API: URL can be unicode, and the returned Headers object is not a dictionary.
Add WebErrorMixin.assertHTTPError, to replace (getPage + shouldHTTPError)
specifically everywhere we use self.shouldRedirect2
This removes many uses of self.POST (since shouldReplaceTo does its own HTTP), which will make it easier to remove client.getPage from POST.
Since POST() is about to lose followRedirect=True
and remove the followRedirect= argument from POST
and update to inlineCallbacks while we're in there
warner
force-pushed
the
2857-deprecations
branch
from
71c6649
to
05317d4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This ought to fix all the outstanding deprecation warnings in the tahoe codebase.
There are two sets of deprecation warnings from outside our control:
OpenSSL.rand): the plan is to remove that importtwisted.conch.ssh.Key.sign()is using a deprecated pyca/Cryptography feature (cryptography/hazmat/backends/openssl/rsa.py, "signer and verifier" are deprecated in favor of "sign and verify"). I haven't yet looked to see if there's already a bug for that one.