2476.add json welcome page.0 #430
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This code looks fine to me too. It might be nice to squash some of this down to fewer commits, but I'm going to practice not being uptight about that :) |
scared about duplicate nodeids in the data getting lost, switch to a list
flat is better than nested
exarkun
force-pushed
the
2476.add_json_welcome_page.0
branch
from
7ca583e
to
1f16a17
Compare
Codecov Report
@@ Coverage Diff @@
## master #430 +/- ##
==========================================
- Coverage 88.02% 88.02% -0.01%
==========================================
Files 147 147
Lines 27820 27836 +16
Branches 3972 3974 +2
==========================================
+ Hits 24489 24503 +14
- Misses 2617 2619 +2
Partials 714 714
Continue to review full report at Codecov.
|
It provides information more correctly obtained from get_connection_status().
|
ok, looks good, merging now |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an update of #399
It's stacked on #429. Review that first (and this branch have history rewritten depending on what happens there).