rewrite the config file more safely #432
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
use cli options for whatever we can use the config apis for the other thing this avoids clobbering configuration we don't know about - such as the storage=False setting (which made all nodes storage servers).
also add missing import!
now that there are only 5 storage servers instead of 8 as expected
Codecov Report
@@ Coverage Diff @@
## master #432 +/- ##
==========================================
+ Coverage 88% 88.05% +0.04%
==========================================
Files 147 147
Lines 27833 27833
Branches 3977 3977
==========================================
+ Hits 24494 24507 +13
+ Misses 2624 2615 -9
+ Partials 715 711 -4
Continue to review full report at Codecov.
|
|
looks good to me! 👍 |
exarkun
deleted the
2895.servers-of-happiness-integration-test-storage-servers
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes https://tahoe-lafs.org/trac/tahoe-lafs/ticket/2895#ticket
And also fixes the failing integration test on travis-ci, apparently, though I don't really know why.