Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use find_packages #433

Merged
merged 1 commit into from
Aug 8, 2017
Merged

Use find_packages #433

merged 1 commit into from
Aug 8, 2017

Conversation

exarkun
Copy link
Member

@exarkun exarkun commented Aug 7, 2017

It is a shorter and more reliably way to provide a value for the packages parameter.

Fixes https://tahoe-lafs.org/trac/tahoe-lafs/ticket/2897

@warner
Copy link
Member

warner commented Aug 8, 2017

#434 is fixed.. wanna rebase and re-push this? I think it should pass CI this time.

It is a shorter and more reliably way to provide a value for the packages parameter.
@codecov-io
Copy link

codecov-io commented Aug 8, 2017

Codecov Report

Merging #433 into master will decrease coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##           master    #433      +/-   ##
=========================================
- Coverage   88.02%     88%   -0.03%     
=========================================
  Files         147     147              
  Lines       27835   27835              
  Branches     3973    3973              
=========================================
- Hits        24501   24495       -6     
- Misses       2619    2624       +5     
- Partials      715     716       +1
Impacted Files Coverage Δ
src/allmydata/mutable/publish.py 95.65% <0%> (-1.02%) ⬇️
src/allmydata/web/status.py 82.86% <0%> (+0.11%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e8699cd...31f4272. Read the comment docs.

@warner
Copy link
Member

warner commented Aug 8, 2017

the coverage issue is unrelated, I'll try to fix that later

+1, will land soon

@warner warner merged commit 31f4272 into tahoe-lafs:master Aug 8, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants