Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use a random port #435

Merged
merged 1 commit into from Aug 8, 2017
Merged

Use a random port #435

merged 1 commit into from Aug 8, 2017

Conversation

meejah
Copy link
Contributor

@meejah meejah commented Aug 8, 2017

(Pulled out of tahoe-invite PR). This at least uses a random port instead of 1234; better would be if we could not listen at all in these tests.

@meejah meejah mentioned this pull request Aug 8, 2017
2 tasks
@codecov-io
Copy link

codecov-io commented Aug 8, 2017

Codecov Report

Merging #435 into master will decrease coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #435      +/-   ##
==========================================
- Coverage   88.02%   88.01%   -0.01%     
==========================================
  Files         147      147              
  Lines       27835    27835              
  Branches     3973     3973              
==========================================
- Hits        24501    24499       -2     
- Misses       2619     2621       +2     
  Partials      715      715
Impacted Files Coverage Δ
src/allmydata/util/dictutil.py 97.19% <0%> (-0.71%) ⬇️
src/allmydata/web/status.py 82.86% <0%> (+0.11%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e8699cd...e2a5751. Read the comment docs.

@warner
Copy link
Member

warner commented Aug 8, 2017

The coverage problem is unrelated.. we need to improve the dictutil tests.

We should probably change these tests so they don't actually have to start up a Tub (maybe mock it out), so the network port shouldn't matter, but this is a good interim fix.

+1, I'll land soon

@warner warner merged commit e2a5751 into tahoe-lafs:master Aug 8, 2017
@meejah meejah deleted the listen-static-port branch March 20, 2018 22:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants