Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove unused classes/functions from dictutil.py #438

Merged
merged 5 commits into from
Aug 15, 2017

Conversation

warner
Copy link
Member

@warner warner commented Aug 13, 2017

I was trying to enhance our unit tests to get full+stable coverage of everything in dictutil.py, when I discovered:

  • we aren't actually using most of it
  • I could replace one large class with collections.defaultdict and itertools.count
  • most of the functionality has since been subsumed by python builtins

So this patch deletes most of dictutil.py and the matching tests. Yay negative code days!

@codecov-io
Copy link

Codecov Report

Merging #438 into master will decrease coverage by 0.16%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #438      +/-   ##
==========================================
- Coverage   88.06%   87.89%   -0.17%     
==========================================
  Files         148      148              
  Lines       27954    27553     -401     
  Branches     3986     3953      -33     
==========================================
- Hits        24617    24219     -398     
+ Misses       2624     2623       -1     
+ Partials      713      711       -2
Impacted Files Coverage Δ
src/allmydata/util/dictutil.py 100% <ø> (+1.62%) ⬆️
src/allmydata/util/nummedobj.py 66.66% <100%> (-1.34%) ⬇️
src/allmydata/stats.py 85.34% <0%> (-0.87%) ⬇️
src/allmydata/immutable/upload.py 95.25% <0%> (-0.28%) ⬇️
src/allmydata/web/status.py 82.86% <0%> (-0.23%) ⬇️
src/allmydata/mutable/servermap.py 94.19% <0%> (+0.48%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d91516a...8dd0a5f. Read the comment docs.

@meejah
Copy link
Contributor

meejah commented Aug 15, 2017

👍 LGTM

@warner warner merged commit 8dd0a5f into tahoe-lafs:master Aug 15, 2017
@warner warner deleted the 2891-remove-numdict branch August 15, 2017 21:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants